Skip to content

chore: migrate grafeas to librarian#8657

Merged
quirogas merged 1 commit into
googleapis:mainfrom
jskeet:migrate-grafeas
Jun 16, 2026
Merged

chore: migrate grafeas to librarian#8657
quirogas merged 1 commit into
googleapis:mainfrom
jskeet:migrate-grafeas

Conversation

@jskeet

@jskeet jskeet commented Jun 16, 2026

Copy link
Copy Markdown
Contributor

No description provided.

@jskeet jskeet requested a review from a team as a code owner June 16, 2026 13:26

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request removes the "skip_generate: true" flag for the Grafeas Node.js library in "librarian.yaml", deletes an OwlBot configuration file, and updates the repository metadata in "packages/grafeas/.repo-metadata.json". The reviewer advised against manually editing ".repo-metadata.json" as it is a generated client configuration file, recommending that any updates be made upstream in the generator instead.

Comment on lines +10 to +11
"name": "containeranalysis",
"name_pretty": "Container Analysis",

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

Please do not manually edit generated client configuration JSON files. Any changes or updates to .repo-metadata.json must be made upstream in the generator.

References
  1. Do not manually edit generated client configuration JSON files. Any changes or updates must be made upstream in the generator.

@quirogas quirogas merged commit bb42f77 into googleapis:main Jun 16, 2026
32 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants